First rOpenSci version
Transfer ownership to rOpenSci
Add .github files
Add reviewers to DESCRIPTION
The goal of this version is to address all issues raised by the rOpenSci editor (Scott Chamberlain) and my two reviewers: Jessica Minnier and Zachary Foster.
URL tag to DESCRIPTION
BugReports tag to DESCRIPTION
Wrapped all lines longer than 80 characters
Removed unused imports
Split test functions into smaller test files
Save metadata as package data:
Add minimum version to
Add space between equal signs in argument lists
Change package name from
Let user set the download directory (defaulting to a tempdir).
devel test to travis
More package-level documentation
Do not export print.OneKP function
Add documentation details to
Update intro vignette
Do not run examples that access the internet (call
There was some overlap between the two reviews, here I just list updates made that are unique to this review.
absolute parameter to
download_* functions. If TRUE, this returns the absolute path to the retrieved data.
Add handling for downloading nothing: if everything is filtered out, just return an empty character vector.
Add test coverage for corner cases
filtering by clade with a clade that is not in the NCBI common tree raises an error.
filtering with valid input, but where no rows are selected, returns a OneKP object with 0 rows (no error).
download an empty object returns an empty vector of filenames (no error)